Youssef Victor

icon indicating a website link https://www.linkedin.com/in/youssef1313/ icon indicating an email [email protected]

icon company Microsoft icon location Prague, Czech Republic icon location Software Engineer, former Microsoft MVP. Working on .NET testing @microsoft. Work email: [email protected]

Results 913 comments of Youssef Victor

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

Going in history to very old commit in dotnet/runtime: https://github.com/dotnet/runtime/blob/f8976a5121b0728679279308d44af1965a9e5ca8/src/installer/corehost/cli/hostmisc/utils.cpp#L351-L359 https://github.com/dotnet/runtime/blob/f8976a5121b0728679279308d44af1965a9e5ca8/src/installer/corehost/cli/fxr_resolver.cpp#L71-L88 It looks like the fallback to `DOTNET_ROOT` isn't there.

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

Behavior change was introduced by https://github.com/dotnet/runtime/pull/53763

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

https://github.com/dotnet/sdk/blob/6142428c690f7c5bd11537e9d55764094055c814/src/Cli/dotnet/Commands/Test/VSTestForwardingApp.cs#L41-L50 This logic looks wrong to me. `VSTEST_WINAPPHOST_` causes testhost to start with `` to the same value (where `` is either `DOTNET_ROOT` or `DOTNET_ROOT(X86)`). The logic is wrong because,...

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

Thanks @elinor-fung. Good to know the motivation for the change introduced in net6.0. Now need to figure out the best way to fix this. Ideally we would just fix the...

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

Yeah .NET 8 SDK as well will likely need a backport if we fix in SDK and not hack it in VSTest. @baronfel Is it okay to have a fix...

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

Ahh yes. Updating Microsoft.NET.Test.Sdk package won't use a newer version of vstest.console, it only uses newer version of testhost. The workaround has to be in vstest.console so it really needs...

[NetTestingE2E][Regression] Error "The library hostfxr.dll was found..." will throw when executing "dotnet test --arch x86 --diag:log1.txt".

@nohwnd We are starting to receive more complaints about this, and I'm not sure if we will now want to backport for .NET 9 SDK.

Improve error message on data row mismatch

Yes, the wording isn't ideal. I thought we had this reported before but can't find an existing issue.

Move ReflectionHelper to PlatformServices

ReflectHelper is relying on ReflectionOptions which I think can't easily be moved to PlatformServices. This also mean that DeploymentUtility may end up not using source-generated reflection operation when it should.

Move ReflectionHelper to PlatformServices

Still relevant as we still have both: https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTestAdapter.PlatformServices/Utilities/ReflectionUtility.cs https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTestAdapter.PlatformServices/Helpers/ReflectHelper.cs But now we can easily unify