Omar Plata Salas

Results 17 comments of Omar Plata Salas

Hello there, I've been taking a look at the code, sorry for the delay on the comment. I think it would help if you spread the code a little across...

I see, that's fair. I too have been tied up by studies lately. Everything seems good, thanks for the explanation. Do tag me whenever you think the PR can be...

Only indexing and upserting when needed, but the collections within the app would be reset, it's more reliable to clear then insert entire ranges with [ObservableRangeCollection](https://gist.github.com/weitzhandler/65ac9113e31d12e697cb58cd92601091#file-rangeobservablecollection-cs). AdvancedCollectionView takes a long...

I also think we should debloat some of the ViewModels and outright remove a few, some do stuff that they shouldn't be responsible for and others just wrap a model...

I was working on improving that internally, but there's lots of code and I don't have much time. Certainly will be improved by the next release though.

Fixed in #222

Edge must now be uninstallable in the EEA, so I guess that's another strike against this proposal.

If Edge isn't on the system, there isn't a suitable PDF preview handler in place anymore - Edge being able to handle this is part of the proposal's title, and...

The workaround of telling the user to install an app they might not even use (Edge) just for a PDF preview isn't good, in my opinion. Specially when we're talking...