Reda Al Sulais
Reda Al Sulais
I think the proposed keywords look great, but a quick question about two-word keywords: should we also support the full version? Or the current ones are fine? i.e., `user journey`,...
> In cases where we "need" to support 2 words, `lowerCamelCase` seems like the right choice, as adding a whitespace might complicate our internals. I wasn't referring to adding whitespace,...
So to summarize what we need to change: - Update the `.jison` grammar to support what have been stated above without breaking existing grammar. - Add a tip tilling users...
`flowchart-v2` and `sankey` are messing. --- I'm not familiar with those `-v2` diagrams; is it a grammar or layout difference?
The only thing left is JSDoc, I'm not really sure what to type, we could discuss it here.
> @Yokozuna59 is this blocked by anything? @sidharthv96 Because E2E tests are failing. Not Really sure why but the options assignment isn't working as expected, for example: https://github.com/mermaid-js/mermaid/actions/runs/5796633792/job/15710598026?pr=4651#step:5:7346 > TypeError:...
> Because E2E tests are failing. Not Really sure why but the options assignment isn't working as expected, for example: https://github.com/mermaid-js/mermaid/actions/runs/5796633792/job/15710598026?pr=4651#step:5:7346 It should be resolved with this c74e55f581a838ecce10c4a07467d3d7af7febef
Since there's a going discussion in #4252 proposing the same thing, I'll close this as duplicate.
@fkohrt Thanks!
Hi there @brvv! How about this? ``` directories file1: f directory1: d file2: file file3: file directory2: d directory3: dir ``` Which output would be (I used text for simple...