Yoann Baron (bary)
Yoann Baron (bary)
Hello @Bertrand2 @odoostan, Since this issue ended up in bugfix I'll allow myself to give my 2 cents on the matter. I couldn't reproduce any wrong contact creation and frankly...
In hindsight this is probably unnecessary complexity for a problem that could be bypassed by adding just 1 min to the starting time of the entry (functionally or automatically even)....
@nle-odoo I've added a test as promised, could I trouble you for a review of it ?
Should be good to go now
Hello @Bertrand2, Could you have a look at the conversation on https://github.com/odoo/odoo/pull/181115 when youu have time ? I think this should be closed but I'm not sure I understand what...
@Bertrand2 Sorry to keep pestering you but there is another thing I don't understand. In cc402049f3d69d46afa8c65a4fa51788335d6ea9 test_accrual_plan_with_multiple_levels_2, we grant days off at the transition date between 2 levels. I've followed...
@robodoo up to master
Messed up my rebase very badly so I just deleted and re-pushed. I can't figure out how to link this back here so I made a new PR for 18.0...