Yoseph Maguire

icon indicating a website link https://yodama.github.io/

icon location Cairo icon location "This is not a duck." Writing code, among other things.

Results 72 comments of Yoseph Maguire

TypeError [ERR_INVALID_URL] after updating to 4.2.3

@youngcholo thanks for filing the issue. What is the connection string you are providing?

TypeError [ERR_INVALID_URL] after updating to 4.2.3

is there a minimal repro you can provide?

TypeError [ERR_INVALID_URL] after updating to 4.2.3

@youngcholo yeah looks like a bug again with the url parsing. Can you incorporate the changes from the PR linked manually and see if they fix things?

TypeError [ERR_INVALID_URL] after updating to 4.2.3

@youngcholo can you check that this is fixed in 4.2.4?

TypeError [ERR_INVALID_URL] after updating to 4.2.3

I see now. Thanks for the repl. This is an issue with the legacy support of url.parse. Will have to see if the changes should be reversed because I did...

TypeError [ERR_INVALID_URL] after updating to 4.2.3

usually when I'm working with a URL for TCP, I will pass the port in during the connection string: ```js mqtt.connect('mqtt://test.mosquitto.org:1883') ```

read ECONNRESET at TCP.onStreamRead

this is an interesting error... We added more clarity on the errors popping up in MQTT.js to users so they could deal with for instance connection errors, but this is...

Read retained-only

@reneklootwijk can you explain more on what the option does? There could be a feature added but I'm not sure if a retained option is available currently in MQTT.js. Are...

wxapp close websocket but MQTT didn't emit 'close' event

can you include logs of this bug.

TypeError: socketTask.onOpen is not a function

it looks like it is in the Alibaba websockets code. I'm not sure the purpose of it. https://github.com/mqttjs/MQTT.js/blob/master/lib/connect/wx.js#L61