Yingbo Ma

Results 223 comments of Yingbo Ma

It's not clear what methods to overload. For instance, for real numbers, we will have `conj(x) = x` etc, and for `

We could construct the characteristic polynomial and introduce the `Root` object ```julia julia> using LinearAlgebra, Symbolics julia> @variables x y λ 3-element Vector{Num}: x y λ julia> A = [0...

FYI, there's https://github.com/JuliaSymbolics/Symbolics.jl/pull/457. But it seems to be slightly buggy. ```julia julia> @register_symbolic oof(x::AbstractVector) julia> @variables x[1:100] 1-element Vector{Symbolics.Arr{Num, 1}}: x[1:100] julia> oof(x) ERROR: MethodError: no method matching oof(::Symbolics.Arr{Num, 1})...

Yeah, I agree. We should check that `args[1]` is not symbolic.

`substitute` doesn't do commutative-associative matching. Have you tried to use `@rule`?

We don't really guarantee a specific ordering, currently. The are arguments are sorted in an ordering that has total order over all expressions.

Haha, that's from our internal discussions. The feature is planned, and we are working on that.

You'd need `PerformanceTestTools.jl` to actually disable bounds checks in test.