Yingbo Ma comments

Results 223 comments of


                                            Yingbo Ma

Observed variables depends on differentiated variable but it's not explicit solved.

I cannot reproduce it. Did you omit the observed function call?

Observed variables depends on differentiated variable but it's not explicit solved.

`sol[model.damper.a_rel]` produces the error. I will fix it.

MTK cannot identify independent variables with new Symbolics convention

@shashi could you take a look?

ModelingToolkit generated functions don't check input dimensions

@shashi can we make `build_function` check the dimension of the inputs even with `checkbounds=false`?

Feature Request: allow references to integrator `dt` in `ODESystem`, automatically generate callback

I thought we already have something similar for the discrete callback thing. @baggepinnen

Passing initial state of submodel silently fails

Use `@unpack x = fol`.

Only force unbound causal inputs to be states

`input=true` forces a variable to be a state is intended. Otherwise users won't be able to change it in a callback.

SplitODEProblem implementation

Could you add tests in `test/odesystem.jl`? Also, please test the Jacobian generation as well.

Implicit DAE observed indexing is broken

https://github.com/SciML/ModelingToolkit.jl/pull/1616 is a good start. We might need interface changes to DAE observed functions from the DAEFunction side, so that observed functions can depend on derivatives as well.

Slow access to solution via symbols

I think `sol[capacitor.v]` is the wrong interface to get the solution in a performant way. It's inherently extremely dynamic. Maybe we should just have something like: ```julia getcv = getfunction(sol,...