Ygg01

Results 44 comments of Ygg01

What would adding the CARGO_WORKSPACE entail. From cursory look, I see [custom_build.rs](https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/cargo_rustc/custom_build.rs#L103) has reference to Context, that has reference to Workspace, but same doesn't exist for [compilation.rs](https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/cargo_rustc/compilation.rs#L153). Would having CARGO_WORKSPACE...

@alexcrichton Yes. I was looking for workspace directory in my custom build script. It's related to servo/html5ever#261. There is a simple workaround of taking `CARGO_MANIFEST_DIR` and using its parent, but...

So if I understand correctly, if I expose [workspace.root_manifest](https://github.com/rust-lang/cargo/blob/master/src/cargo/core/workspace.rs#L33) that would be workspace dir of all projects in workspace, correct? Then I can just: ```rust if let Some(workspace_dir) = cx.ws.root_manifest()...

@alexcrichton I am total newb, but won't adding `Cargo.toml` to workspace root, return the location of workspace manifest as opposed to directory of the directory in which workspace manifest is?

Hm, while writing tests, I've noticed a peculiarity. I assume I'm using this wrong. But I wanted to double check ```rust let p = project("foo") .file("Cargo.toml", r#" [project] name =...

@alexcrichton Is there an alternative way to test env. variables are properly set in each member build script?

Yes, I think that is correct (one call to `cargo build` in member directory and one call in workspace directory). Are there any examples of such code? I can only...

@withoutboats my original motivation for this feature was when html5ever, was moving from one project per workspace to multiple. Namely some tests that were specific, became shared and not in...

So should we just make `CARGO_WORKSPACE_DIR` be convenience for `workspace_root` from `cargo metadata --format-version=1`?

One way to test is to generate some garbage file and try loading it base64 /dev/urandom | head -c 1000000000 > file.txt For inspiration, you might look at https://github.com/arximboldi/ewig It...