Yicong Chen comments

Repositories
Issues
Comments

Results 4 comments of


                                            Yicong Chen

Vite's "transformIndexHtml" hook is not invoked on build

+1. I have to do this to make sure local dev build and production build have the same: In `vite.config.js`, for dev build: ```diff import { defineConfig } from "vite"...

User ID ignored during user creation using the REST API

We also have struggled with this for years.

Bigger (and readable) image size in ImageColumn

I noticed that you pass in `rowHeight` to the data grid: https://github.com/streamlit/streamlit/blob/6fd61726188f87b326ab75a8e6305c0827456fa3/frontend/lib/src/components/widgets/DataFrame/DataFrame.tsx#L570C11-L570C20 Why not just expose this constant as a configurable variable to `data_editor`?

`set-output` command is deprecated

> get-version-action @dhkatz I tried your fork. In your doc it says use `dhkatz/get-version-action@v3` but v3 is not available. I guess you wanted people to use the tag `dhkatz/[email protected]`, or...