Jeroen van Hoof

Results 14 comments of Jeroen van Hoof

Hmm... I can also set `self.best_estimator_ = self`. Then I can just define the `classes_` property myself.

Hi @rsaccon, sounds like a cool project :smile: - The vertices (`v.vertices`) have an attribute `connected_edges` that contains a list of all the half-edges that have their origin at this...

Hi @rsaccon, thank you for reporting this. I checked it, and indeed `new_edge.twin` seems to be the correct edge to add. Before: ![image](https://user-images.githubusercontent.com/4205641/111038745-e2976e80-842a-11eb-97fe-592991d451a0.png) After: ![image](https://user-images.githubusercontent.com/4205641/111038748-e6c38c00-842a-11eb-8d41-52cbede398b3.png) Let me dive a bit...

Hi @rsaccon, your fix is included in the code now. Thank you very much! Please let me know if there are still issues that are not solved with this, or...

Hi @rsaccon, just letting you know that this is going to be fixed in the upcoming version. I have created a new method to clean up zero length edges, that...

Hi @rsaccon, thanks again for making me aware of this issue! My latest commit https://github.com/Yatoom/voronoi/commit/9b7875e5fdc5744f238a767d184e1f2dade70202 should deal with this problem. Hope this helps! :smile: For your other question about minimum...

Hi @rsaccon, I think I replaced lists with sets somewhere which might cause the randomness. I'll look into it when I have some time. Nice work on those updates by...

Thanks @mars0001, there seems to be an issue with this case indeed. I will investigate this further. I'm putting this here so that we have a reproducible script. ``` import...

This issue was caused by rounding errors, which in turn caused the circle events to be executed in the wrong order. Thanks for your help. If you find anything else...

Thanks Marius/@mars0001! In that case let me reopen this issue. Those grids are indeed a bit tricky as they require special/careful handling when multiple events happen on the same line...