Joe Smith

Thanks for the good idea, @Stretch96 ! We're trying out a [`pre-commit`](https://pre-commit.com) hook that requires manually dropping a file into [a child module](https://github.com/neuralinkcorp/terraform-pre-commit/blob/master/hooks/terraform-validate.sh). It's mostly self-documenting, but that extra random...

Darn it autocorrect...

Took a quick glance here, and [naming this `Dimension` would collide with the type in `Foundation`](https://github.com/apple/swift-corelibs-foundation/blob/3e5366251756d7ffcf289c0faff865ca7dd23417/Foundation/Unit.swift#L195). Maybe we could call it `MetricDimension` ? This could be a usability win since...

Great eyes! If this gets a 👍, it'll also be worth it for someone in the community to evaluate [other projects](https://github.com/apple/swift-nio/blob/master/scripts/generate_docs.sh#L110) since they'll benefit from the fix too.

> Failure is missing license headers: > > ` * bash... missing headers in file './scripts/pre-commit.sh'!` > > Can you please add @Yasumoto ? Ah, it’s a little more nuanced:...

Rad, updated to use the existing `sanity.sh`. Great idea!

I ran [ShellCheck](https://github.com/koalaman/shellcheck) on the script as well, I considered but backed away from adding it to the `sanity.sh` script since I didn't want to change too much at once....

Just curious, have [you seen this post before](https://stackoverflow.com/a/53409142)? Another option to get a snapshot dump directly is [`zkSnapShotToolkit`](http://zookeeper.apache.org/doc/current/zookeeperTools.html#zkSnapShotToolkit). For restoration, what about just using a backed up snapshot? In terms...

A few other weekend-projects have come up the last 2 weeks- but I'm hopeful I've cleared the way this weekend. If someone wants to snag this in the meantime, feel...

I've [got a rough draft out at that (surprisingly?) has passing tests](https://github.com/Yasumoto/commons/tree/yasumoto/rm_c_zookeeper), however I need to review the diff to make sure my edits were ~correct. One thing I've done...