Iaroslav Igoshev

Results 189 comments of Iaroslav Igoshev

@AndreyPavlenko, please ping me when comments are addressed.

No, I mean when all comments are addressed and the PR is ready for review again.

Please resolve the comments which are addressed for better understanding.

@AndreyPavlenko, please apply all suggestions I left (even those which are in the hidden conversation, just roll out it to see). If something is not applicable, please resolve those and...

> > Aside: It would be better to address comments in separate commits to make it easier for reviewers inspect changes. > > Should I do multiple commits (one per...

@AndreyPavlenko, please resolve conflicts.

We do preserve lengths and widths for a binary operation so closing this issue. Feel free to reopen if needed. https://github.com/modin-project/modin/blob/7c835a2761ede41d402c1febd29826c1d0b9512f/modin/core/dataframe/pandas/dataframe/dataframe.py#L3752-L3753

When running the example from the issue description I see the following timings. ```bash modin 0.27.0+8.g4704751c4 0.04345369338989258 pandas 0.05070161819458008 ``` I think we can close this as resolved but if...

We do preserve lengths and widths in _compute_dtypes since tree_reduce pattern is used there so closing this issue. Follow https://github.com/modin-project/modin/issues/2751 for potential optimizations in _compute_dtypes.

@naren-ponder, do you have a plan to continue this?