modin
modin copied to clipboard
FEAT-#4605: Handle small and empty dataframes
Signed-off-by: Naren Krishna [email protected]
What do these changes do?
- [x] commit message follows format outlined here
- [ ] passes
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
- [ ] passes
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
- [ ] signed commit with
git commit -s
- [ ] Resolves #4605 ?
- [ ] tests added and passing
- [ ] module layout described at
docs/development/architecture.rst
is up-to-date - [ ] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release
Great! Looking forward to see these changes in
This pull request introduces 11 alerts when merging 90ca31181c9c76b0ec27a3fc551356f9df9e4870 into 3982306a540bd09b43a21dcdca6b16b4741ed151 - view on LGTM.com
new alerts:
- 10 for Unused import
- 1 for `__init__` method returns a value
This pull request introduces 11 alerts when merging fc42bd4d1a1024b6b6b6fa2503385b6a313dcbd4 into eddfda4b521366c628596dcb5c21775c7f50eec1 - view on LGTM.com
new alerts:
- 11 for Unused import
@naren-ponder Any plans here?
Codecov Report
Merging #4606 (e4a2856) into master (f5f4c16) will increase coverage by
16.00%
. The diff coverage is28.90%
.
@@ Coverage Diff @@
## master #4606 +/- ##
===========================================
+ Coverage 71.43% 87.43% +16.00%
===========================================
Files 259 261 +2
Lines 19198 19609 +411
===========================================
+ Hits 13714 17146 +3432
+ Misses 5484 2463 -3021
Impacted Files | Coverage Δ | |
---|---|---|
...ore/storage_formats/pandas/small_query_compiler.py | 28.00% <28.00%> (ø) |
|
modin/pandas/dataframe.py | 91.69% <66.66%> (+0.13%) |
:arrow_up: |
...in/core/dataframe/algebra/default2pandas/binary.py | 36.84% <0.00%> (-57.90%) |
:arrow_down: |
.../core/dataframe/algebra/default2pandas/resample.py | 50.00% <0.00%> (-44.45%) |
:arrow_down: |
...n/core/dataframe/algebra/default2pandas/rolling.py | 56.25% <0.00%> (-37.50%) |
:arrow_down: |
modin/core/storage_formats/base/query_compiler.py | 68.86% <0.00%> (-30.36%) |
:arrow_down: |
...n/core/dataframe/algebra/default2pandas/groupby.py | 71.83% <0.00%> (-24.65%) |
:arrow_down: |
modin/core/dataframe/algebra/default2pandas/cat.py | 83.33% <0.00%> (-16.67%) |
:arrow_down: |
modin/core/dataframe/algebra/default2pandas/str.py | 83.33% <0.00%> (-16.67%) |
:arrow_down: |
...n/core/dataframe/algebra/default2pandas/default.py | 87.93% <0.00%> (-8.63%) |
:arrow_down: |
... and 76 more |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@naren-ponder were you planning to add any tests to this PR?
Any progress here?
@Garra1980 yes, @Billy2551 is going to be taking this on. It'll probably be in a new PR, but we will keep this one up for now.
@naren-ponder, do you have a plan to continue this?