Dirk Avery

Results 54 comments of Dirk Avery

Hi! 👋 Consistency is the key behind this. The tool has "Argument Reference" (non-plural) but "Attribute_s_ Reference" (plural) instead of "Attribute Reference" (non-plural). Non-plural is correct but it's self inconsistent...

@robbycuenot I am not able to reproduce this error with v5.50.0. Let me know if my process below misses something key to reproducing this. Otherwise, if we can't figure a...

Okay, so looking again at this. (@joshgubler as an aside, mentioning this benefitting BYU will get you many more points than say, for instance, mentioning UofU!) **Explanation of the Issue:**...

Looks like more CI tests are failing. In addition, I'm getting these errors when running: #### `us-west-2`: If it's only available in certain regions, the tests need gates. ```console ingestion_test.go:156:...

I confirmed that this is still happening and happens with `mysql`/`aurora-mysql` as well.

Thanks for raising this and our apologies for the delay. This will be fixed with #40281.

**Update:** There are two changes here. The first is to _not_ remove default tags from volume tags. ~This seems like a no-brainer _yes_. Volume tags do not have the `tags`/`tags_all`...

After some fixes... ```console % make t T=TestAccEC2Instance_BlockDeviceTags K=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1...

Due to crucial role of tagging and that this change could affect tags provider wide, additional testing: ```console % make t T=TestAccEC2InstanceDataSource_tags K=ec2 make: Verifying source code with gofmt... ==>...

Closed with #42098 and (mostly) #41775