Steven Tang

Results 21 comments of Steven Tang

https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/src/index.js#L350-L354 https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/test/legacy-tests.test.js#L525-L532 https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/test/legacy-tests.test.js#L540-L547 The tests seem to be inconsistent as to what should be passed in the `touch` function.

If the cookie is updated due to `rolling`, I think it makes sense for `session.cookie` and its expiry to be updated accordingly also. https://github.com/expressjs/session/issues/33#issuecomment-42497814

I did a few tests on the effects of `resave` and `rolling`. ``` v3 resave: true, rolling: true expires, session.cookie.expires updates resave: true, rolling: false expires, session.cookie.expires updates resave: false,...

Maybe it will be better to roll back the change first. I'm currently unsure about the effects of `expires` and `session.cookie.expires` and whether they should always stay in sync. To...

#### Current Behavior | resave | rolling | expires | session.expires | | ----------- | ----------- | ---- | --- | | false | false | y | n |...

Here are the logs from the different cases. ``` resave: true, rolling: true 2021-08-07T06:00:39.109Z connect-mongo create MongoStore instance 2021-08-07T06:00:39.113Z connect-mongo Creating MongoDB TTL index Sat, 07 Aug 2021 06:00:39 GMT...

Since it's not perhaps very clear how this mechanism works, it might be beneficial to write some integration tests against `express-session`. Unassigning myself for now...

@Genei180 Thanks for including the fix. Looks like there're now conflicts in `README.md` though.

May I ask how you plan to implement it? I'm a bit concerned about security. I think at least a log of some sort will need to be updated when...