Xuyang Song

Do we still need the `combineIntents()` API? I remember we discussed the partial transaction struct in the meeting earlier.

Some problems needed to discuss with Vampir Team: https://github.com/anoma/taiga/pull/157#issuecomment-1519080215 The basic underlying gadgets we need to create Taiga Predicate(mandatory/basic constraints): Poseidon hash, Elliptic curve operation(addition and multiplication), sinsemilla commitment

Some improvements to be made: - [x] Export the instances(public inputs) from vamp_ir. fixed by #166 - [x] Correctly handle the instances(public inputs) from vamp_ir. There might be a bug...

> Remove the `params` from the `VampIRValidityPredicateCircuit` when vamp_ir supports setting the params size manually. Some VampIR VP circuit tests failed because of the small `params`. It will be solved...

> `createEncData()` Actually because nullifier keys stored in the notes are short-term, we don’t need a separate call for that and can put it inside the createPtx() call. Is this...

> `retrieveVP()` Solvers need information about the VPs in order to be able to satisfy them efficiently. There was some design question around that, was it resolved? Not yet. Solvers...

- [ ] A simple merkle hash tree: we build the tree from leaves and get the leaf with its corresponding path (no need for insert, append or remove operations)....

The nullifier key commitment has a useless zero (`nk_cm = Com(nk, zero)`). We could use the space for key management. Or we could put the nullifier key in the new...

doc: https://hackmd.io/@yulia/sudoku Circuit details: - Dealer Intent App VP 1. check `app_data = hash(encoded_puzzle || sudoku_app_vk)` 2. if it is an output note, there are no constraints 3. if it...

Some minor TODO lists - [ ] Sudoku state encoding constraints in application vp - [ ] Add the constraints for non_zero_sudoku_cells assignment in [check_puzzle](https://github.com/anoma/taiga/blob/f62275706abb462d83853b3505f0020210199626/taiga_halo2/examples/taiga_sudoku/app_vp.rs#L218) - [ ] Consider if...