Xunzhuo

Results 151 comments of Xunzhuo

Hi @craigbox thanks for your kind tips, template updated, please take a look

Ops, I think I know what is tricky here: the `mutex` is a global lock: https://github.com/kiali/kiali/blob/master/kubernetes/client_factory.go#L19 In `TestClientExpiry`: https://github.com/kiali/kiali/blob/master/kubernetes/client_factory_test.go#L14 After executing `getClientFactory`, goroutines start to run `watchClients` and they are...

In an elegant way, we should use channel to tell goroutine to recycle this client, not for sleep and loop to read the cliententries.

Hi @lucasponce thanks for commenting, I have replied in the Pr.

Thanks @jshaughn, problem is solved with CR config :)

Just for a suggestion, if it is able to turn on/off this mode manually, it would be a better choice in user and experience :)

Hi, thanks for your report. This direction is what I am working on. Actually for now, I think the support for external control plane in Kiali needs more discussions and...

If this is acceptable, I am willing to assign this job.

If no one is available, I would like to help do this in the next week:)

Yes, I took a couple of days on vacation in recent months, and just come back to work. I could work on this in my free time recently @smauermann