Xiretza

Results 96 comments of Xiretza

Personally I'd prefer a builtin subcommand over polluting the variable namespace even more, especially with this kind of magic variable that isn't really a variable but more of a function...

I don't think etebase-server depends on watchgod? It's only a transitive dependency through uvicorn, so if that gets moved to another package it shouldn't affect etebase-server.

That sounds like a problem with GTKWave, not ghdl.

> An optional sep in a separated list is conceptually invalid You present this as fact when it's really just your opinion. The difference between `separated_list` and a prefix/suffix per...

What do you mean by "the error detail is never used"? That's entirely up to the implementor of [`FromExternalError`](https://docs.rs/nom/7.1.3/nom/error/trait.FromExternalError.html).

A slightly less awkward workaround is to specify the type of the literal directly (i.e. `1_usize`), but that's obviously still not ideal.

Wouldn't this be better implemented as a separate crate, much like https://crates.io/crates/nom-leb128? nom itself really only provides the most fundamental parsers and combinators.

I think for this to go into nom proper, there would have to be parsers for every integer type at the very least; though I wouldn't put too much effort...

The `master` branch contains examples for the code found on `master` (which now includes the `fold` combinator). For examples for nom `7.x`, check the [`7.x` branch](https://github.com/rust-bakery/nom/tree/7.x/examples) or, better yet, the...