Xiretza

Results 96 comments of Xiretza

Sure, sounds like it might be useful, but your implementation would actually be unsound for the general (generic) case - [`InputTake`](https://docs.rs/nom/latest/nom/trait.InputTake.html) is safe to implement, so there's nothing stopping an...

`bytes::complete::take` is just a wrapper around `InputTake::take_split` with not additional checks.

My point is that you can't rely on that with unsafe code, the trait is safe to implement and can thus return whatever it wants. It doesn't really matter though,...

Have you seen https://github.com/Geal/nom#example?

This is the error your example produces: ``` Error: Parsing Failure: ("-02-07T03:00:50\",\n \"domain\": \"REDACTED\",\n \"hostname\": \"REDACTED\",\n \"result\": {\n \"urlworker\": {\n \"ip\": \"REDACTED\",\n \"http_code\": 200\n },\n \"safebrowsing\": {\n \"matches\": []\n }\n...

Sounds like it might be a good addition after #1402 lands. Right now, there are already too many parsers in this space, duplicating some of them to allow passing a...

I think the main problem is that your `Tokens::Words` contains a `&str`, which means it references a direct slice of the input. That's not what you want though, you want...

The overall structure looks great for a comprehensive tutorial, which is something that nom kind of lacks right now (there is some tutorial-style documentation in `docs/`, but it's not as...

I could've sworn there was a `void` combinator for this, but apparently not. It can be emulated with `value((), p)`, but I agree it'd be a good addition to the...

This is intended behaviour. By using `bytes::streaming::take`, you're opting in to it - there is no way to know if this is actually the end of the data or if...