Xaymar
FWIW, the use of `auto` is fine, but the use of explicit types should be preferred for code clarity. As it is, this PR sacrifices code clarity for slightly more...
> how readable is the code? In the example you provided you can either opt for `decltype(...)::iterator` or `const auto&`, but not `auto`. This is because `auto` by itself drastically...
Forgot to mention the other problem of `const char*` possibly being a `nullptr`, thus invoking undefined behavior in many compilers and libraries that are still being supported. Therefore the use...
> should const char* be changed to std::string_view? Only if we control the entire initialization part of std::string_view. It should not be changed to std::string_view if it faces an external...
Will test this on all platforms this weekend. If it fails, I'll reject the PR, if it works, I'll merge.
There's only a rebase left, as well as verifying that the & doesn't cause memory corruptions.
As I'm preparing to build for Qt6+OBS Studio 28.0, testing for this is a bit delayed still. I handled the rebasing and commit style though, so that part is done.
@abebeos > I have the feeling that the effort here (and similar within https://github.com/Xaymar/obs-StreamFX/issues/859 https://github.com/Xaymar/obs-StreamFX/issues/857) is beyond a $500 bounty budget. The budget is based on income via Patreon or...
> would it be possible to update functionality incrementally (e.g. using both, ~StreamFX~ direct AMD AMF and FFmpeg for different functionality) ? This is the intended path, if it ends...