Vincenzo Chianese comments

Results 132 comments of


                                            Vincenzo Chianese

Decoded JWT is not being saved in req.user when verified

This is on purpose. Express Gateway will never touch your request body — if you need to forward it somehow you need effectively to use the request transformed to add...

Empty string shouldn't be allowed as basic-auth/oauth2 custom password

Definitely true. Thanks for the report, I’ll look into this.

Empty string shouldn't be allowed as basic-auth/oauth2 custom password

Note to self: this requires a lot of efforts. 1. Make the JSON schema validation on the Admin API 2. Cleanup the credentials schema (requires an huge refactoring effort to...

Tests aren't cleaning up the resorces

With mocha 4.0 this is now kind of a priority. Mocha now does not exit anymore in case there are pending handles (such as sockets, file descriptors and shit like...

Bump express-rate-limit to 5.0.0

@sanyamdogra Not too fast my friend — that would be a breaking change. We are going to need to keep such parameters and write a layer that would still use...

Bump express-rate-limit to 5.0.0

I believe that part of features has just been moved to another package; you'd need to install that into express gateway as well and use it.

Bump express-rate-limit to 5.0.0

All right, let’s melt them together.

When tokenType = jwt, scope restriction doesn't work.

As a self reminder, we have two issues here: 1. The JWT specification does not have anything regards the scopes property. Some uses `scope`, some `scopes`. Moreover, some uses it...

When tokenType = jwt, scope restriction doesn't work.

Yes — you're experiencing exactly the same issue. I wrote you a workaround in the Gitter channel (that is — use [this](https://github.com/XVincentX/apigateway-playground/blob/monolith-hypermedia/gateway/jwtScopes.js))

When tokenType = jwt, scope restriction doesn't work.

@naprime What policy are you referring to?