express-gateway icon indicating copy to clipboard operation
express-gateway copied to clipboard

Empty string shouldn't be allowed as basic-auth/oauth2 custom password

Open kolbinski opened this issue 7 years ago • 2 comments

Now, with empty string as a password, such credential is created.

kolbinski avatar Aug 01 '18 16:08 kolbinski

Definitely true. Thanks for the report, I’ll look into this.

XVincentX avatar Aug 01 '18 16:08 XVincentX

Note to self: this requires a lot of efforts.

  1. Make the JSON schema validation on the Admin API
  2. Cleanup the credentials schema (requires an huge refactoring effort to make the thing decent)

XVincentX avatar Aug 01 '18 20:08 XVincentX