XIVStats-Gatherer-Java icon indicating copy to clipboard operation
XIVStats-Gatherer-Java copied to clipboard

Published 20 hours ago • verified publisher icon XIVStats

Set up CI with Azure Pipelines

Open ReidWeb opened this issue 6 years ago • 6 comments

ReidWeb avatar May 12 '19 08:05 ReidWeb

Please do not accept yet

ReidWeb avatar May 12 '19 08:05 ReidWeb

👍

matthewhillier avatar May 12 '19 11:05 matthewhillier

Should be ready for acceptance once we get a passing build - configured baseline, and hooked in Jonathan's test DB.

I'll look to get a docker defined test db running at some pt, and bring in the code cov stats again

ReidWeb avatar May 12 '19 11:05 ReidWeb

Sincerest apologies for the notification spam, not sure what caused that

ReidWeb avatar May 12 '19 11:05 ReidWeb

@matthewhillier looking at an alternate CI (Travis), having an issue with one of the tests in this run, any speculation as to the cause?

ReidWeb avatar Jun 15 '19 17:06 ReidWeb

Hey @ReidWeb - I think I found one test in my latest branch which had an overly-strict test against a live character (https://github.com/XIVStats/XIVStats-Gatherer-Java/pull/51/files#diff-38deaf8a51cc511381feab7299f7940cR97).

I've fixed in my branch, but you may need to replicate in yours or we'll need to merge in this change.

matthewhillier avatar Jun 17 '19 13:06 matthewhillier