Dennis C

diesieben sniped me a little here: I don't think putting the "burden" for such a feature on everyone implementing `IClientItemExtension` is a good idea. Every implementation would either be exactly...

That would still make it a breaking change because you would need to enforce the use of `ClientItemExtensionImpl` by changing the generic type in the consumer in `Item#initializeClient()` and also...

The `IClientItemExtension` interface is not new, it was just renamed from `IItemRenderProperties`

I still think a completely separate data structure is cleaner than trying to tack this onto `IClientItemExtension`

The `create(String name, boolean twoHanded)` method (https://github.com/MinecraftForge/MinecraftForge/pull/8419/files#diff-749c2dfa55244df387a9ad0634c39aa2c8b29d4e6c1c3a7827e29bbf592d10f8R42-R44) is unnecessary IMO because modders should never register a custom `ArmPose` without an accompanying `IForgeArmPose`. The `forgeArmPose` parameter of the `create(String name, boolean...

I see can how this may be confusing, but to clear it up: you only need to match *a* constructor, matching all of them is not necessary.

That's the rather bad file naming of geckolib, for some reason they put the loader in front of the mod name...

I have played a bit with this PR, specifically the dynamic geometry event. In general it seems pretty solid to me. The only thing I noticed is that while solid...

The `ChunkRenderDispatcher.RenderChunk.RebuildTask` where the static geometry event is fired extends `ChunkRenderDispatcher.RenderChunk.ChunkCompileTask`, which in turn has a copy of all `IModelData` from the chunk the task is working on. Allowing access...

So you essentially want something similar to the existing `ModelDataManager` but not bound to a block in the world and instead to a chunk or chunk section, correct?