Simon Heather

Results 82 comments of Simon Heather

Thanks for this @marcus-rev. Can you add a unit test for this change, and confirm in the PR description that you have tested this in your own local environment.

OK. I suggest this detail is added to the documentation as it is not obvious looking at the dockerfile and causes confusion like in https://github.com/terraform-aws-modules/terraform-aws-atlantis/issues/382.

The policy check tests in `events_controller_e2e_test.go` are failing on this change and need fixing.

@bakayolo, can you update the PR title and description with the new flag name? Some new unit tests for this flag also need to be added to verify it is...

The documentation needs updating to add this new flag here: https://github.com/runatlantis/atlantis/blob/main/runatlantis.io/docs/server-configuration.md

@bakayolo, can you resolve the merge conflicts?

Thanks for this @bakayolo. You can test it using one of these container images: [dev-alpine-841f7b4](https://github.com/orgs/runatlantis/packages/container/atlantis/300230701?tag=dev-alpine-841f7b4) or [dev-debian-841f7b4](https://github.com/orgs/runatlantis/packages/container/atlantis/300230413?tag=dev-debian-841f7b4)

Thanks for this @oleg-glushak. Can you check the linting error: https://github.com/runatlantis/atlantis/pull/5241/files#annotation_30986616047

I'm not keen on just ignoring the linter with a generic message. Can you investigate further? Also, can you try and avoid force pushing changes to the branch if you...