Simon Heather

Results 77 comments of Simon Heather

Yes agreed. Each function needs to be considered separately.

I would also suggest that rather than using `throw`, the module should use a helper function to build a `System.Management.Automation.ErrorRecord` object then call `$PSCmdlet.ThrowTerminatingError`. See [Error Handling in PowerShell -...

I'll take a look at it once PR #177 is merged, as that PR is making significant changes to the `Invoke-GHRestMethod` function.

How about just converting the file, it is then transparent to the user? Do the same byte check then read the file and write back out with the required encoding...

I've raised PR #205 which adds output types and views for the `GitHubRepositories` module. This should give you the pattern to add types and views to the other modules.

It would seem a shame to lose the depth of the integration tests that are currently being run, as these will always be better than any mock based tests. Have...

[Create or update a file](https://developer.github.com/v3/repos/contents/#create-or-update-a-file) has been completed in PR #241.

I've written a script which produces a report on the current MetaTest OptIn Status of all the DSC resource modules listed within this repo: [DscResources-MetaTest-OptIn](https://github.com/X-Guardian/DscResources-MetaTest-OptIn). Thought it might be useful.

https://help.github.com/en/github/building-a-strong-community/changing-access-permissions-for-wikis. I'm sure these were restricted when they were under the PowerShell account.

I've got the same issue: ## Steps to Reproduce ``` $ModuleName = TestModule $OutputFolder = ".\Modules\$ModuleName\Docs" $ModulePagePath = ".\Modules\$ModuleName\README.md" New-MarkdownHelp -Module $ModuleName -OutputFolder $OutputFolder -WithModulePage -ModulePagePath $ModulePagePath -Force ``` ##...