André Guilherme
André Guilherme
@sahlberg close this
https://github.com/sahlberg/libsmb2/commit/4331dc5b026a9a4bd085425f744d812840997c23
> sorry my keyboard goes cappital setting or sommeting on windows i messed with Capital Letters goes brrr.
> @cjlano Pinging to check in on a possible followup to this PR? he´s not online nowadays...
> @Wolf3s Is this repository being maintained? If so, is there anyone who would be able to take a look at this? No fork found that was being active
It didn´t compile on both windows and linux!
Both compiled successfully, but this request i think it´s not good, in some parts of the code
Fixing this warning will possibly lead to another problems.
> Few conversion warnings still remains in MSVC, I think we should fix them too @Wolf3s Yes it should, mainly on the x64 part.
> My test cases in AMSMB2 run successfully. These changes should not lead to any issue as the the types are wider. Also some variables that contain length are became...