Greg Korba

Results 540 comments of Greg Korba

Check [this one](https://regex101.com/r/gz7K1V/2) 😉 ![image](https://user-images.githubusercontent.com/600668/203679273-bf3f6e13-a56b-40b3-a6dc-8e8e2eeb1df9.png)

@alexander-schranz do I understand correctly that such PR should provide changes in 2 files that you [mentioned earlier](#issuecomment-1325736783) (plus 3rd revision of the [regex](https://regex101.com/r/4Uanps/2))?

FYI: I did not add fixtures for constants use as keys, so @tacman can do it, but I suggest to merge #4484 first and then add such examples to `packages/config-transformer/tests/Converter/ConfigFormatConverter/YamlToPhp/Fixture/normal/constant.yaml`...

@alcohol can you point me to that "bashbrew script"? What's failing?

Thank you both of you, @gsherwood and @jrfnl for your time spent on this project. Much appreciated 🍻. Pity that project couldn't be transferred, would make the transition smoother. PS....

@liquid207 is it possible to rebase this PR, so we can check current pipeline result and continue the review process? Also, I am not sure if fixer with `strpos` in...

@keradus @kubawerlos I've restored this PR as-is (only resolved conflicts and fixed CI), but we need to decide if these cases should really be handled by this fixer ([as I...

Can't reproduce on 3.16-DEV (current master), using provided config. Snippet 1: ![image](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/600668/41857f66-a96c-404d-8065-4af7234868dc) Snippet 2: ![image](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/600668/2e5effbd-71eb-4c8e-860c-186e29b57985) Snippet 3: ![image](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/600668/cea281c2-0168-4a98-804f-046d77f4db43) I'm going to close this as completed, it had to be fixed...

@YLivay there's nothing to be fixed - [mixing indentation in Heredoc is not allowed in PHP](https://3v4l.org/VDpAJ). Such code causes parse error on PHP level and Fixer ignores such files because...

I am going to close this since it's already available to achieve with explicit custom config using existing options.