WillieHabi
WillieHabi
> > > Are we sure that when a client says they support v2 that the only signals we send through are ISentSignalMessage_s? The rest will just get dropped. This...
I updated the logic so now it checks for the correct v2 signal type and if the type is invalid it responds with a nack message. Similar to what what...
> I tried to scan just the latest test changes, but couldn't quite follow some of them. If you have not already, you should make sure that it is possible...
re-requesting review on the code changes so far, still a few open discussions to resolve around array type checking and supportedFeaturesMap
> And I think that we also don't have throttling coverage nor did the in place logic get changed. Client targeted signals should have different computation than broadcast signals. Unless...
> > > And I think that we also don't have throttling coverage nor did the in place logic get changed. Client targeted signals should have different computation than broadcast...