Wilfred Hughes

Results 601 comments of Wilfred Hughes

I think this is #30 again.

![Screenshot from 2022-03-06 21-43-20](https://user-images.githubusercontent.com/70800/156974725-3f8cabf2-7d09-4ef6-9b33-6b289eff5031.png) Current behaviour, note incorrect `.` highlighting (should be the . on the previous line).

Old: ``` fn diff_file() { let rhs_binary = true; if rhs_binary { print!("{}", style::header(display_path, 1, 1, "binary")); return; } let extension = 1; } ``` New: ``` fn diff_file() {...

errors.mli in HHVM 71abf8d56763d497e95c1e79e13724e6e103c32d is another good example. It might benefit from never splitting a LHS top-level node over multiple RHS top-level nodes. IIRC Autochrome has some ideas in this...

Giving top-level lists a bigger discount for being wholly novel might help matters.

Deadgrep 14c7d6b74c7891ed7294abe1a6f5914948e4ab49 has an interesting example where `deadgrep--directory` has its body factored out.

But deadgrep bdcdf138cd71b0a5a80ca64b3bd68b7355084757 is an example where defining a new function `deadgrep--escape-backslash` is considered as partially reused.

This has improved, but it's still skipping the opposite lines.

Ooh, are you interested in packaging difftastic @jirutka? That'd be really neat. This seems like a reasonable feature to add, but it'll require a few fiddly details: (1) Difftastic doesn't...