Wilfred Hughes

Results 601 comments of Wilfred Hughes

@crides agreed, configurable file associations would be nice. (FWIW I'm not sure Kicad would work well as there's no generic s-expression parser in difftastic today.)

https://github.com/torvalds/linux/blob/v5.17/fs/io_uring.c https://github.com/torvalds/linux/blob/v5.16/fs/io_uring.c

Looks like a few cases weren't split up well, leading to nodes with >2000 children being diffed. Logging would really benefit from time information, and maybe treating larger node counts...

The particularly slow nodes: ``` WARN difft::dijkstra > LHS nodes: 646 (10 toplevel), RHS nodes: 657 (10 toplevel) WARN difft::dijkstra > Time: 41.266267ms WARN difft::dijkstra > LHS nodes: 631 (2...

The slowest region is the novel section starting at RHS `io_init_poll_iocb`. The LHS function `__io_arm_poll_handler` has been split between several RHS functions. This is particularly unfortunate given that RHS has...

It might be worth setting a baseline diff of everything being novel, and giving up if the cost exceeds 90% of the worst case. There would need to be a...

What's your C/C++ compiler, and what version?

Strange, that's a recent version of clang (googling suggests it's a xcode 13: https://gist.github.com/yamaya/2924292#file-xcode-clang-vers-L418) and I'm not sure what's wrong. Difftastic does now have a macOS build and releases with...

Looking at your build error, it looks like mimalloc failed to compile. I've since updated mimalloc, and recent versions (e.g. 1.7.3) report having macOS fixes: https://github.com/microsoft/mimalloc#releases Feel free to reopen...

Hmm, I'm afraid I'm not very familiar with `--dir-diff` or meld. Difftastic already supports being passed directories as arguments. What's missing for this use case?