Rik Smale

Results 361 comments of Rik Smale

With the community we might be able to accommodate for using both v2 and v3 of umzug in cli v6, but since umzug v3 does have its breaking changes we...

Tagging @profnandaa @ezkemboi @rubiin @braaar since I'm interested to see what they think. Personally, I think adding additional maintainers would be better for the project and I would refrain from...

Hi! Haven't had the time to fully check this out, but do I understand correctly that it might be better to solve this in sequelize-pool? If so, maybe you could...

I see the name of this PR changed, I think as maintainers we prefer #14687 over this PR. @lohart13 @ephys maybe you can discuss amongst each other if there is...

> I'm keeping this branch updated as I'm using it in a project. Ah, I didn't know but in that case it makes sense to keep this updated. Thanks for...

Likely due to this, so if we fix the TODO this issue should also be fixed; https://github.com/sequelize/sequelize/blob/c8829daefa6b49b9920824bb7528343c56a4b5c0/packages/core/src/dialects/abstract/query-generator.js#L1590-L1591

@abradley2 feel free to take this up. It seems that DB2 has some additional logic that you need to take into account here

Tests are breaking due to https://github.com/tediousjs/tedious/pull/1597 Will need to check further if this is something we want to fix in our test data or that we want to open a...

Actually this is picked up due to our new test function. I might just add the depreciation code to the ignored depreciations list first