Westbrook Johnson

Results 527 comments of Westbrook Johnson

There is one issue, it seems the settings as they are now do output a reference to `global.Promise` when processing `@skatejs/element`, which bombs in the browser: ``` function delay(fn) {...

Whoops, this isn't about color, it's about the use of the `:before` pseudo element is `position: absolute` which places it _over_ the icon when the hover state is activated.

This applies in some cases to the left edge of the content area as well: ![image](https://user-images.githubusercontent.com/1156657/162537566-5e91c6dd-8ec9-4571-a9fa-4d7cb2642b91.png) CC: @joekukish

Trying to get Playwright to support us in doing this, here: https://github.com/microsoft/playwright/issues/4591

Might the be something that could find its way into the Express pass on this pattern?

Will these icon specific size classes be required after this change? https://github.com/adobe/spectrum-css/blob/tshirt-size-workflow-icon-continue/components/icon/workflow-icons.css#L21-L65

I think I misstated my question... Good to hear that is wouldn't be required! Would Spectrum CSS still maintain those classes for optional use, going forward?

I'd less call this "reaching into" a component than defining what _scope_ a component is delivered in, which would lead me to think that a ProgressBar effecting a FieldLabel internal...

Please take a look at https://github.com/adobe/spectrum-web-components/blob/main/packages/field-group/src/spectrum-config.js#L22-L33 where you should be able to update to `selector` values for the new classes names. You'll need to run `yarn` to ensure the new...

I menu is not _technically_ allowed to have this type of content. Can you share some more information about the larger interaction at play here so that we might address...