spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

[Slider] Range slider track is given wrong "margin-block-start"

Open Westbrook opened this issue 4 years ago • 1 comments

The roughly margin-block-start: -1px; rule in the following line:

https://github.com/adobe/spectrum-css/blob/842406ad3e9da3a652f2d76acddeba3b5d02ecc3/components/slider/index.css#L109

Is overridden as margin-block-start: 0; in the following line:

https://github.com/adobe/spectrum-css/blob/main/components/slider/index.css#L180

Naively, the following would appear to cure this situation:

margin-block: calc(var(--spectrum-slider-track-height) / -2) var(--spectrum-slider-range-track-reset);

I'd be happy to submit a PR if this seemed appropriate.

Westbrook avatar Jun 11 '21 01:06 Westbrook

Might the be something that could find its way into the Express pass on this pattern?

Westbrook avatar Nov 02 '21 20:11 Westbrook