Westbrook Johnson

Results 527 comments of Westbrook Johnson

This seems right to me. Is there something specific about it has you unsure?

There are conflicts in this branch... 😢

Please add tests cases for the various input modalities covered in this change to the PR description.

@loredanaspataru as we work towards an API that works for everyone here, can you help us confirm the actual level of flexibility we'd be looking for in a pattern like...

It would be great if there wasn't a requirement for both the label and the picker to notate the label location. In that way, when this is "done" then the...

> ``` >if (this.hasAttribute('side-aligned')) { > this.resolvedElement.element?.setAttribute('sideLabel', 'true'); > } > ``` Roughly, yes. This versions applied this value to everything, which may be right, but may not happen with...

It's a requirement of delivering tooltip content accessibly that the pointer can enter the temporary content. We'd definitely accept a contribution that stopped propagation of click events on `` elements.

Could similar be achieved by moving the application of `selected` from the declarative renderer to something like: ``` protected override updated(): void { if (this.selects) { (this.shadowRoot.querySelector('sp-menu') as Menu).selected= this.value...

> When the `selects` attribute is not present a `value` will not be maintained and the Menu Item children of this Menu will not have their `selected` state managed. No...

What happens if you change https://github.com/adobe/spectrum-web-components/blob/main/packages/menu/src/Menu.ts#L95 to be if (selected === this.selected || !this.selects) {`? There's also likely a reasonable path to retiring a test or two if we need...