Weihan Li

Results 183 comments of Weihan Li

I'm also confused on whether a totp is used more than once, have you found a solution? @OmarAlBchouti I guess we should remain the totp and matchedStep in our business...

Yeah, thanks @eddieysong

maybe `HttpContext.RequestAborted` can be used for Ocelot inner handle to support for request abort

Sorry @jurgi, I'd not elaborated clearly ,that's not been implemented by `Ocelot` for now, just a mind on Ocelot.

There's a bug fix with HttpClient `FormUrlEncodedContent`, could we have a patch release with this bug fix, maybe with the next patch release is better issue: pr:

Is your HashSet value too large? You can try to increase your Redis timeout to see if it helps

Similar issue with version `2.2.4` ``` System.ObjectDisposedException: Cannot access a disposed object. Object name: 'consumer-75787c44d5-sr9rk'. at StackExchange.Redis.ConnectionMultiplexer.ExecuteAsyncImpl[T](Message message, ResultProcessor`1 processor, Object state, ServerEndPoint server) in /_/src/StackExchange.Redis/ConnectionMultiplexer.cs:line 2698 at StackExchange.Redis.RedisBase.ExecuteAsync[T](Message message,...

I think maybe it's better to add a new method to avoid breaking changes, for example: For `XTRIM`: ``` c# StreamTrimWithMinId(RedisKey key, RedisValue minId, bool useApproximateMaxLength = false, CommandFlags flags...

Hi @NickCraver, @mgravell, any thoughts on this? If we could accept breaking changes, I think maybe it's better to add support for a trim policy, maybe something like follows: ```...