Maxime Dupuis comments

Results 16 comments of


                                            Maxime Dupuis

Idea - Generic wait_until(predicate_func, timeout) & reaching max_time should fail the test & providing predicate functions like is_object_freed

Ok I understand now. I think having both a waiting function AND an asserting function makes it too complicated. In most cases, one could split it in two lines like...

Idea - Generic wait_until(predicate_func, timeout) & reaching max_time should fail the test & providing predicate functions like is_object_freed

Great! Yeah the custom messages is gonna be tricky. Good point that we don't need to figure those yet for assert_eventually() to work.

Idea - Generic wait_until(predicate_func, timeout) & reaching max_time should fail the test & providing predicate functions like is_object_freed

Yes I'm happy to do it. Might take a while though, I'm just hobbying around. So if you get inspired feel free to do it! We can post progress here,...

Idea - Generic wait_until(predicate_func, timeout) & reaching max_time should fail the test & providing predicate functions like is_object_freed

Starting work on it

Idea - Generic wait_until(predicate_func, timeout) & reaching max_time should fail the test & providing predicate functions like is_object_freed

Resolved by https://github.com/bitwes/Gut/pull/609 @bitwes your Awaiter trick works. Let me know what you think 🤞 I called it `assert_eventually`, but it's not a strong preference. Pick whichever name fits best...

Stream logs during `--wait`

@ndeloof AFTER the `docker compose up --wait --logs` command fails, could we dump the logs of the healthcheck-failing containers? Could be an easier first step and help troubleshoot most cases.