Maxime Dupuis
Maxime Dupuis
Thanks! Hey let's hold on for this PR until we resolve https://github.com/bitwes/Gut/issues/585, as it might be a more generic solution. I don't have permission for it, but you can mark...
Closing in favor of: https://github.com/bitwes/Gut/pull/609
If it helps, the [doc ](https://gut.readthedocs.io/en/latest/Quick-Start.html#await) says > It’s best to wait at least 2 frames as waiting one frame can be flaky I'm not in the same situation as...
Yes that works, or we can do my current workaround: ```` func after_each() -> void: for child in get_children(): autofree(child) ```
Are you aware of a use-case where someone would NOT want to free all children? If everyone, like me, always `autofree` all children, maybe we could move that to GUT...
It's not easy to express with just an isolated example. But imagine a bigger project, with many tests instantiating a object that might add siblings. For a concrete example, in...
I agree that it's good testing practice to clear children between scripts. And it's usually a good practice to clear them between each test. Good tests should be independent. I...
Yeah that's a tricky one to avoid breaking existing tests. IF you agree GUT should clear children between each test, maybe it could be in the next major version. Meanwhile...
# wait_XXXXXXXX shouldn't fail Agreed. Very good point for the complex setup and not caring if the condition becomes true # Naming it as wait_then_assert..... VS assert_eventually..... I like both....
``` await assert_eventually( signaler.is_connected.bind('the_signal', connector.callback), assert_signal_connected.bind(signaler, connector, 'the_signal'), 5, 'wait for it to be connected or 5 seconds, then assert it is connected') ``` I'm not sure I understand the...