Ward Fisher comments

Results 558 comments of


                                            Ward Fisher

Switch custom Bzip2 cmake module to standard

This *is* working for me on MacOS so I'll see if I can figure out what's happening on Ubuntu 22.04.

Switch custom Bzip2 cmake module to standard

Dennis, I'll have to dig to see what's installed as part of the development packages re: 'bz2 vs. bzip2', but the library itself is libbz2, so I would suspect bz2.

Switch custom Bzip2 cmake module to standard

Re-checking these PR's in an attempt to get caught up on the backlog.

Switch custom Bzip2 cmake module to standard

@K20shores Can you take a look at the conflict and confirm where this should go instead, keeping in line with the changes you've made?

Bzip2/Bz2 confusion in Cmake build

Thanks! I'll take a look.

Incompatible function pointer when building with clang-16

Interesting, thank you for letting us know. I will take a look.

Documentation partially built, not installing

Hi Gus, the documentation, when built, does not install, but I suppose there's no reason for it not to. I can update this so that the generated files are installed...

nc_put_var_double execution time increases in subsequent runs when a variable is written with chunking and compression

Thanks for your patience; I suspect this is an HDF5 issue (similar to other recent netCDF4 speed issues only observed on Windows), but will see if I can replicate!

CMake: Add option to always automatically regenerate `ncgen` source

This looks good; I may change the option name to keep it consistent with the `autotools`-based system (from which `make makeparser` was inherited. As long as the option remains off...

Macro named '_FillValue' conflicts with libc++ headers

I suspect we should be able to refactor this out, while leaving the name of attribute alone (as we'd expect). Tagging this for the upcoming release, it should (ideally) be...