Ward Fisher comments

Results 558 comments of


                                            Ward Fisher

Testings imple szip filter setup Unexpected Result

Note: This only occurs using `cmake`.

Testings imple szip filter setup Unexpected Result

I'm wondering if this block of `nc_test4/tsts_vars3.c` should be split off into a new test file that can be fenceposted via `ENABLE_FILTER_TESTING`; it feels like szip should not be part...

Testings imple szip filter setup Unexpected Result

Rather, as always, I'll wish I had considered it before asserting an answer, if I don't.

Testings imple szip filter setup Unexpected Result

@DennisHeimbigner sure thing: * [libnetcdf.settings.txt](https://github.com/Unidata/netcdf-c/files/8961501/libnetcdf.settings.txt)

cmake exported target uses undefined hdf5::hdf5 imported target

The netCDFConfig.cmake file is generated automatically; let me take a look to see if I can find out how it is properly modified/updated.

cmake exported target uses undefined hdf5::hdf5 imported target

Coming back to revisit 4.7.1 issues in the lead-up to the release. @jschueller thanks for the pointer.

cmake exported target uses undefined hdf5::hdf5 imported target

@jschueller Indeed.

cmake exported target uses undefined hdf5::hdf5 imported target

Addressing this now before it slips under the radar again.

cmake exported target uses undefined hdf5::hdf5 imported target

Yes, the logic for HDF5 is tricky. Thanks for checking in, I was going to ask, once I had something that looked like a fix. I imagine I'll need to...

Allow explicit disable of optional dependencies

Agreed. '--disable-zstandard-plugin' will be included in the upcoming maintenance release, and is in the current development branch.