Brian Ward

Results 559 comments of Brian Ward

Honestly, the lazy code motion pass seems to me to be _so_ broken that I'm not even positive this is worth fixing. The very next line is ``` stan::model::assign(theta, lcm_sym7__,...

The message we have says > C++17 support is mandatory in the next release of Stan. I think it’s fine? People can always use older versions, and basic C++17 support...

@SteveBronder are you hoping to get this in before the release? I noticed the makefile changes would also be useful for #3110

`laplace_marginal_neg_binomial_log_summary_lpmf_test` took ~5 hours to run (not counting compilation) on the latest push. `laplace_marginal_poisson_log_lpmf_test` took even longer. I don't think we can (unconditionally, at least) run those kinds of test...

Changing the namespace of is_tuple will also require changes up in Stan. Not sure it's worth doing as part of this

Without ASAN, the laplace tests only took 16 minutes? Does that sound right? @SteveBronder

16 minutes -> 4 hours using ASAN is one of the worst slowdowns I’ve ever seen for a sanitizer run. Wow

> Can you add examples of how the names for these would look like? It would be good to recognize complex and tuples even if there would not be support...

It looks like the rev files are also doing the tests that should belong in prim, if they were following the folder structure exactly