Brian Ward

The two arguments there are test group and test name, so you can just write the logAddExp without having to do any more code

@serban-nicusor-toptal @rok-cesnovar do we even use this github action? It seems like at least the stanc portion of it has fallen out of date

Why are you providing a path to the exe file if you don't want it to use that file? I think it would be reasonable to make the change you...

I think the new APIs look nice. I still have some concerns about the implementations, especially things like sample means vs population means, and how difficult it is to tell...

I’m not seeing anything abnormal - latest run failed due to excess compiler warnings

Yes, because this PR is causing 4 new compiler warnings which is crossing the threshold of what we allow in CI: https://jenkins.flatironinstitute.org/job/Stan/job/Stan/job/PR-3305/27/pipeline_clang/folder.1689781376/

The node warning is not the source of the error, its ``` [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from ServicesLaplaceJacobian...

Looking at the laplace test, it is setting up a writer without a comment prefix `stan::callbacks::stream_writer sample_writer(sample1_ss, "");` and then later feeding that back into the csv_reader, which is now...

I am still not sure I follow what the goal of this PR is -- is there a bug it is fixing?

Ah, I missed how this would fix reading adaptation. That is nice to have. How positive are we that nobody uses the warmup draws read in by this class? I...