Walter Smuts

Results 51 comments of Walter Smuts

> If you would like to implement this, the better way to do this is by adding a function to the Game structure. I think you're right :) > There...

I've gone ahead and factored the PR into smaller commits to make it easier to review. Here are the commit messages: ``` commit 5cff4b423ddd7f2386bb366f34316902dbef985d Author: Walter Smuts Date: Tue Mar...

> I think we can remove en_passant_target from the Board structure. I'm not so sure. There is no context to infer `en_passant` from only the `Board` struct. This is because...

Made the `get_pseudo_fen` function crate local and implemented proper deserialization and updated the test to enforce that.

> This is a pretty major concern: the FEN (even when formatted correctly) does not contain enough information to allow a chess game to be resumed. Agreed. The FEN format...

> if you were to make it work on Game I'd be happy to review it. I originally disagreed with this... but now am considering. Stay tuned!

> Do you know any readline-like library (in any language) which supports such feature ? Nope. Looked around a bit and couldn't find anything. > Except for the clear_screen command,...

@H-M-H Do you mind pointing us to an example of how you use your version of the library to add `rustyline` support to `tui-rs`?