Caleb Burks

Results 91 comments of Caleb Burks

Another example in #108663-zd for more study when addressing this.

Thought about this some more, and I'm thinking this is actually functionality that belongs in its own module. There is more to this than just receiving notifications. The module's purpose...

Similar: - https://wordpress.org/plugins/revisionary/ - https://wordpress.org/plugins/revision-manager-tmc/ - https://wordpress.org/plugins/revisionize/

Noting that Gutenberg does avoid this issue. Saving/changing post statuses doesn't force the full page to refresh, so any content in metaboxes and other fields is not lost. Given the...

I believe this could be solved with the filter added in https://github.com/Automattic/Edit-Flow/issues/417

This would be a good time to separate out the module loading process. There could be a separate class responsible for holding all the instances of modules (with register/unregister/get methods)....

Multiple inheritance patterns like this could get pretty messy down the road. If a set of related helper methods are needed for specific modules, what do you think about using...

Looking better. I have a couple of thoughts: 1) I'm not a big fan of the current GB compatibility implementation. Seems to obfuscate quite a bit with little advantage and...

This would be good to get patched, as it causes fatals on all non-VIP sites running up to date versions of PHP. The only uses of these two functions can...

Linking to the new PR for this: https://github.com/Automattic/Edit-Flow/pull/563