Dieter Beck
Dieter Beck
Thank you for working on this! I just applied the changes to my own project which doesn't use any `View` annotation/attribute - everything does still work like expected.
> This includes a hard B/C break by removing the class inheritance, the @View annotation class would no longer pass a class_exists(Sensio\Bundle\FrameworkExtraBundle\Configuration\Template::class); check as a result of this change. That's...
I tested this branch in one of my projects and it worked fine. @mbabker Thank you for the hard work!
> No, because our programmers added and changed code wich was not pushed towards github. In this case I don't think that the maintainer of this package can help you....
@ixarlie FYI CI has been fixed in `master`.
@ixarlie Are you still working on this PR or should someone else take it over?
@ixarlie Thank you for updating this PR! The code LGTM. However, I don't have the possibility to test the changes since I don't use the annotations in my project. @goetas...
@bradjones1 Thank you for merging. Can you please tag a new release?
> Do you think that we should keep `Until` and `Since` attributes or they should be deprecated? @scyzoryck Good point. I think they should be deprecated since version constraints provide...
I don't think that the `1.0.x` example from the docs have ever worked. > It would be nice to move to https://github.com/composer/semver instead of version_compare I gave this a try...