Hateoas icon indicating copy to clipboard operation
Hateoas copied to clipboard

Issue 325 php8 attributes

Open ixarlie opened this issue 2 years ago • 9 comments

resolves #325

To be precise the php version must be 8.1 or greater to support nested attributes.

ixarlie avatar Jan 10 '23 21:01 ixarlie

@ixarlie FYI CI has been fixed in master.

W0rma avatar Jan 31 '23 15:01 W0rma

@W0rma branch was updated with master. Thanks

ixarlie avatar Jan 31 '23 17:01 ixarlie

Is anyone handling this PR?

fabianoroberto avatar Jan 03 '24 14:01 fabianoroberto

@ixarlie Are you still working on this PR or should someone else take it over?

W0rma avatar Jan 09 '24 06:01 W0rma

@ixarlie Are you still working on this PR or should someone else take it over?

@W0rma Hi, sorry for the late response. Yes, I can still work on it.

I worked on this some time ago, my concern is whether the approach I've copied from JMS is still valid for this or whether there are better ways to accomplish it.

In any case, let me go over your comments.

Thanks

ixarlie avatar Jan 11 '24 22:01 ixarlie

@ixarlie Thank you for updating this PR!

The code LGTM. However, I don't have the possibility to test the changes since I don't use the annotations in my project.

@goetas Any thoughts about the implementation in this PR?

W0rma avatar Jan 13 '24 14:01 W0rma

I will look at it mid February, sorry busy times 😞😢

goetas avatar Jan 13 '24 15:01 goetas

Hello, Is anyone handling this PR?

jeandonaldroselin avatar May 15 '24 17:05 jeandonaldroselin

This PR can also move the doctrine/annotation in suggested requirement to enable some project using it to remove the doctrine/annotation dependencies?

jbcr avatar Jun 12 '24 09:06 jbcr