Brandon Kite

Results 134 comments of Brandon Kite

Also consider other opcodes related to contracts that might be useful, such as code size

Nice finds! These are real bugs, the SortedTxCursor decodes block height using `u32::from_str(block_height)` but the display impl for BlockHeight does indeed use `::fmt(&self, f)`. `BlockHeight` used to be a type-alias...

note: thiserror currently doesn't support no-std (although neither does std::error::Error).

If we support schnorr signatures in the future we may want to revisit this. As it would allow you to use a single signature/witness for several different pubkeys derived from...

@xgreenx this seems like a strange modification to me, why are we wrapping everything from storage into arcs?

Looks like clippy has a lint for unchecked math, `cargo clippy -- -D clippy::integer_arithmetic` which results in 135 errors currently. Once we've addressed this issue, we can add `clippy::integer_arithmetic` to...

Initial benchmarking shows we need to increase minimum fee based on predicates & per signature recovery, potentially adjust gas_per_byte / how bytes are metered.

One thing to note, we'd need to come up with an alternate way to set the change outputs on create txs for any unused fees. Deploy currently only inserts the...

We should also verify the behavior in other opcodes besides call