Felix Paulusma

Results 88 comments of Felix Paulusma

Thank you for the PR! :pray: I'll try to review this more seriously in the next month.

Oh, and rebase onto master, please. The CI has been fixed.

Good catch. Also important 👍

Did you build with `-Wunused-imports` and `-Wunused-packages`? Just to be sure we're not depending on, or importing unnecessary packages/modules?

Looks good 💯 thanks for the PR! Will merge after #87 👌 Though please add a link to this PR and your credits to the Changelog in `password-instances`. Just like...

Ah, yes. `optparse-applicative` has a newer version we can probably allow. Not sure if I like the repetition of the `Testing` segment in all the modules. But then again, it's...

Ah, nevermind. I've literally asked for that in the #83 issue. 🤦 I would like to also see the second part of the checkboxes of the issue's first post ticked...

I personally was looking for a function that is even more "specific" than the `differenceAndUnion` one; the following is my naive implementation that feels like it should be more optimal...