Alex Wichmann

Results 41 comments of Alex Wichmann

Not actually building anything with this. I was diving into uri-templates as i maintain a library for deserializing asyncapi.net, and had to figure out how it worked. I came across...

Great work on the spec side so far! Let me know if you need help on the implementation side 👍

Only have a few minor things, otherwise its looking great!

@Gadam8 looks great in its current iteration. What do you think?

> > @Gadam8 looks great in its current iteration. What do you think? > > > > Thank you! Yeah I'm happy with how these changes look 👍 Happy to...

The Specification specifically states > examples | [string] | An array of examples of the server variable. So not serializing it seems correct as a null array is not a...

> This seems to be stripping out the `messageId` property from the message definitions, which is a required property in the 2.x version of asyncapi and so the output produced...

> It looks like it's not being included in the serialised output, upstream, here: https://github.com/LEGO/AsyncAPI.NET/blob/main/src/LEGO.AsyncAPI/Models/AsyncApiMessage.cs#L118 > > > > > MessageId has never been required as far as I know....

this should already be covered by the asyncapi.net change. Although the hook to add it, should be added to the atribute.

Technically, the new behavior is correct. From https://spec.openapis.org/oas/v3.0.3#paths-object >A relative path to an individual endpoint. The field name MUST begin with a forward slash (/). The path is appended (no...