LEGO
feat: extend AWS policy
About the PR
The current AWS policy binding configuration doesn't match what is offered by AWS when configuring IAM policies. Condition and Resource are missing and Principal isn't fully fleshed out. e.g. https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_condition.html#Condition-multiple-conditions & https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html. This PR addresses this by extending the binding configuration for SNS and SQS.
See related JSON bindings PR here - https://github.com/asyncapi/spec-json-schemas/pull/553
Changelog
- Add: Resource property to AWS Statement class for both SNS and SQS
- Add: Condition property to AWS Statement class for both SNS and SQS
- Amend: Changed type for Principal property in AWS Statement to allow for full implementation
Related Issues
N/A
Great work on the spec side so far! Let me know if you need help on the implementation side 👍
Great work on the spec side so far! Let me know if you need help on the implementation side 👍
Thank you! I've just pushed some changes to align with the recent spec changes. Would appreciate a review and any feedback 🙏
@Gadam8 looks great in its current iteration. What do you think?
Thank you! Yeah I'm happy with how these changes look 👍 Happy to proceed
Thanks for the merge @VisualBean! What's the process for releasing a new version? Is it possible to get a beta release now? Thanks 👍
@Gadam8 looks great in its current iteration. What do you think?
Thank you! Yeah I'm happy with how these changes look 👍 Happy to proceed
Yeah ill rebase it to the vnext branch and release a new beta nuget (probably before end of day today).
Edit: Ive pushed a beta release with the new binding changes.